Skip to content

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Nov 6, 2025

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

RSP

@rspbot
Copy link

rspbot commented Nov 7, 2025

@rspbot
Copy link

rspbot commented Nov 7, 2025

@rspbot
Copy link

rspbot commented Nov 10, 2025

@rspbot
Copy link

rspbot commented Nov 11, 2025

@rspbot
Copy link

rspbot commented Nov 14, 2025

@rspbot
Copy link

rspbot commented Nov 14, 2025

## API Changes

@react-spectrum/s2

/@react-spectrum/s2:EditableCell

 EditableCell {
-  action?: string | FormHTMLAttributes<HTMLFormElement>['action']
   align?: 'start' | 'center' | 'end' = 'start'
   children: ReactNode
   colSpan?: number
   id?: Key
   isSaving?: boolean
-  onCancel?: () => void
-  onSubmit?: (FormEvent<HTMLFormElement>) => void
+  onSubmit: () => void
   renderEditing: () => ReactNode
   showDivider?: boolean
   textValue?: string
 }

@react-stately/data

/@react-stately/data:ListData

 ListData <T> {
   addKeysToSelection: (Selection) => void
   append: (Array<T>) => void
   filterText: string
   getItem: (Key) => T | undefined
   insert: (number, Array<T>) => void
   insertAfter: (Key, Array<T>) => void
   insertBefore: (Key, Array<T>) => void
   items: Array<T>
   move: (Key, number) => void
   moveAfter: (Key, Iterable<Key>) => void
   moveBefore: (Key, Iterable<Key>) => void
   prepend: (Array<T>) => void
   remove: (Array<Key>) => void
   removeKeysFromSelection: (Selection) => void
   removeSelectedItems: () => void
   selectedKeys: Selection
   setFilterText: (string) => void
   setSelectedKeys: (Selection) => void
-  update: (Key, T | (T) => T) => void
+  update: (Key, T) => void
 }

/@react-stately/data:AsyncListData

 AsyncListData <T> {
   addKeysToSelection: (Selection) => void
   append: (Array<T>) => void
   error?: Error
   filterText: string
   getItem: (Key) => T | undefined
   insert: (number, Array<T>) => void
   insertAfter: (Key, Array<T>) => void
   insertBefore: (Key, Array<T>) => void
   isLoading: boolean
   items: Array<T>
   loadMore: () => void
   loadingState: LoadingState
   move: (Key, number) => void
   moveAfter: (Key, Iterable<Key>) => void
   moveBefore: (Key, Iterable<Key>) => void
   prepend: (Array<T>) => void
   reload: () => void
   remove: (Array<Key>) => void
   removeKeysFromSelection: (Selection) => void
   removeSelectedItems: () => void
   selectedKeys: Selection
   setFilterText: (string) => void
   setSelectedKeys: (Selection) => void
   sort: (SortDescriptor) => void
   sortDescriptor?: SortDescriptor
-  update: (Key, T | (T) => T) => void
+  update: (Key, T) => void
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants